Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Fix CHANGELOG.md after resource module rename #919

Merged
merged 2 commits into from
Nov 29, 2017

Conversation

johlju
Copy link
Member

@johlju johlju commented Nov 28, 2017

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
Fixes #916

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@johlju
Copy link
Member Author

johlju commented Nov 28, 2017

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju
Copy link
Member Author

johlju commented Nov 28, 2017

:LGTM:


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Nov 28, 2017
@codecov-io
Copy link

codecov-io commented Nov 28, 2017

Codecov Report

Merging #919 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #919   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        32     32           
  Lines      3513   3513           
===================================
  Hits       3393   3393           
  Misses      120    120

@randomnote1
Copy link
Contributor

Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.


CHANGELOG.md, line 6 at r1 (raw file):

- BREAKING CHANGE: Resource module has been renamed to SqlServerDsc
  ([issue #916](https://github.com/PowerShell/xSQLServer/issues/916)).

This should be https://github.com/PowerShell/SqlServerDsc/issues/916 I think. It appears the link still works though.


CHANGELOG.md, line 8 at r1 (raw file):

xSQLServer
This should be SqlServerDsc


Comments from Reviewable

@johlju
Copy link
Member Author

johlju commented Nov 29, 2017

Thanks for catching that! Copy paste error :/


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


CHANGELOG.md, line 6 at r1 (raw file):

Previously, randomnote1 (Dan Reist) wrote…

This should be https://github.com/PowerShell/SqlServerDsc/issues/916 I think. It appears the link still works though.

Done.


CHANGELOG.md, line 8 at r1 (raw file):

Previously, randomnote1 (Dan Reist) wrote…

xSQLServer
This should be SqlServerDsc

Done.


Comments from Reviewable

@randomnote1
Copy link
Contributor

Sure thing!
:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@johlju johlju merged commit 99ad8a2 into dsccommunity:dev Nov 29, 2017
@vors vors removed the needs review The pull request needs a code review. label Nov 29, 2017
@johlju johlju deleted the fix-changelog-new-name branch December 5, 2017 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BREAKING CHANGE: SqlServerDsc: The resource module has been renamed
4 participants